signature authentication for public links #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
C0rby
force-pushed
the
public-link-signature
branch
from
1446ee5
to
de48538
Compare
|
@ishank011 we would like to bring that into the release. Could you do a fastlane 🏎️ review? |
C0rby
force-pushed
the
public-link-signature
branch
from
de48538
to
775cfc0
Compare
ishank011
suggested changes
Mar 26, 2021
internal/grpc/services/publicshareprovider/publicshareprovider.go
Outdated
Show resolved
Hide resolved
internal/grpc/services/publicstorageprovider/publicstorageprovider.go
Outdated
Show resolved
Hide resolved
pkg/cbox/publicshare/sql/sql.go
Outdated
| switch { | ||
| case auth.Password != "": | ||
| return checkPasswordHash(auth.Password, pw) | ||
| case auth.Signature != publicshare.Signature{}: |
There was a problem hiding this comment.
Are you sure this condition isn't true when auth.Signature is nil?
There was a problem hiding this comment.
auth.Signature can't be nil.
Implemented the mechanism proposed here: cs3org/cs3apis#110. The signature authentication is limited to downloads.
C0rby
force-pushed
the
public-link-signature
branch
from
775cfc0
to
e0e0250
Compare
ishank011
approved these changes
Mar 26, 2021
17 tasks
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Apr 19, 2021
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the mechanism proposed here: cs3org/cs3apis#110.
The signature authentication is limited to downloads.