Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL driver for share manager #1224

Merged
merged 7 commits into from
Nov 9, 2020
Merged

Conversation

ishank011
Copy link
Contributor

SQL driver for share manager

@update-docs
Copy link

update-docs bot commented Oct 6, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request introduces 1 alert when merging 6a99621 into 4a9be34 - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request introduces 2 alerts when merging e4f31a4 into 4a9be34 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2020

This pull request introduces 2 alerts when merging c9dc75c into 4a9be34 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@ishank011 ishank011 marked this pull request as ready for review October 8, 2020 09:47
@labkode
Copy link
Member

labkode commented Oct 8, 2020

@ishank011 can we have the cbox specific developments in a folder named "cbox" as we do for owncloud?
We need to do it also for Grappa-like implementations.

@ishank011
Copy link
Contributor Author

@labkode good idea! Reorganized the cernbox specific packages

@ishank011 ishank011 force-pushed the shares-sql-driver branch 3 times, most recently from 2a3de84 to 2b62d94 Compare October 9, 2020 14:47
labkode
labkode previously approved these changes Nov 9, 2020
@labkode
Copy link
Member

labkode commented Nov 9, 2020

@ishank011 can you rebase and I merge?

@labkode labkode self-requested a review November 9, 2020 13:58
@labkode labkode merged commit ffba160 into cs3org:master Nov 9, 2020
@ishank011 ishank011 deleted the shares-sql-driver branch November 10, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants