Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Add api trashbin tests #1123

Merged
merged 4 commits into from
Aug 27, 2020
Merged

[Tests-Only] Add api trashbin tests #1123

merged 4 commits into from
Aug 27, 2020

Conversation

phil-davis
Copy link
Contributor

Description

This PR adds apiTrashbin bug verification scenarios.

The same as PR owncloud/ocis#489 and PR owncloud/ocis-reva#453

This enables future developers to be able to see the behavior in tests while they are understanding and fixing.

@phil-davis phil-davis marked this pull request as ready for review August 26, 2020 13:18
@PVince81
Copy link
Contributor

PVince81 commented Aug 26, 2020

for some reasons some of these tests have been reported unexpectedly passing in my new PR: #1125

ishank011
ishank011 previously approved these changes Aug 26, 2020
@phil-davis
Copy link
Contributor Author

for some reasons some of these tests have been reported unexpectedly passing in my new PR: #1125

This PR is adding local bug-demo scenarios. It does not adjust expected-failures from core.

@phil-davis
Copy link
Contributor Author

@ishank011 @labkode these scenarios might work better or differently after #1125 - I will rebase this...

@phil-davis
Copy link
Contributor Author

Local API tests: https://cloud.drone.io/cs3org/reva/2402/4/7

136 scenarios (136 passed)
1078 steps (1078 passed)
2m36.41s (17.07Mb)
runsh: Total 136 scenarios (136 passed, 0 failed)
runsh: Exit code of main run: 0
runsh: There were no unexpected failures.
runsh: There were no unexpected success.

oC10 core API tests:

runsh: Total 1112 scenarios (434 passed, 678 failed)
runsh: Exit code of main run: 1
runsh: Exit code after checking expected failures: 0
runsh: There were no unexpected failures.
runsh: There were no unexpected success.

Looks good.

@labkode @ishank011 please review-approve-merge.

@ishank011 ishank011 merged commit 6cf7912 into cs3org:master Aug 27, 2020
@phil-davis phil-davis deleted the trashbin-ocis branch August 27, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants