Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calens check to verify changelog entries in CI #1077

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Add calens check to verify changelog entries in CI #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fd9a3f
Add calens check to verify changelog entries in CI
ishank011 Aug 11, 2020
4122f75
Negative test
ishank011 Aug 11, 2020
ebccc15
Revert negative test
ishank011 Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ steps:
- name: changelog
image: golang:1.13
commands:
- make release-deps && /go/bin/calens > /dev/null
- make check-changelog-drone PR=$DRONE_PULL_REQUEST
environment:
GITHUB_API_TOKEN:
Expand Down
3 changes: 3 additions & 0 deletions changelog/unreleased/calens-check-ci.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Enhancement: Add calens check to verify changelog entries in CI

https://github.com/cs3org/reva/pull/1077
6 changes: 2 additions & 4 deletions tools/check-changelog/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,8 @@ func main() {
prID := flag.Int("pr", 0, "the ID of the PR")
flag.Parse()

if *prID > 0 {
if skipPR(*prID) {
return
}
if *prID > 0 && skipPR(*prID) {
return
}

branch := "master"
Expand Down