Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve timestamp precision while logging #1059

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Improve timestamp precision while logging #1059

merged 1 commit into from
Aug 5, 2020

Conversation

ishank011
Copy link
Contributor

@labkode this probably won't break log-parsing in ocis as it overrides the format, but it'd good to confirm once.

@ishank011 ishank011 requested a review from labkode as a code owner August 5, 2020 15:07
@labkode
Copy link
Member

labkode commented Aug 5, 2020

@butonic @refs please check if in OCIS the timestamp is similar. As far as I understand you pass your own logger to Reva.

@labkode labkode merged commit 9f01d21 into cs3org:master Aug 5, 2020
@ishank011 ishank011 deleted the log-time-precision branch August 5, 2020 15:47
@butonic butonic mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishank011 @labkode