better user names in wopi apps

cs3org · Sep 27, 2022 · a272109 · a272109
1 parent 3fb6add
commit a272109
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/changelog/unreleased/better-usernames.md b/changelog/unreleased/better-usernames.md
@@ -0,0 +1,5 @@
+Bugfix: Use Displayname in wopi apps and fix publicshares
+
+We now use the users display name in wopi apps and do not set the userid in publicshares.
+
+https://github.com/cs3org/reva/pull/3282
diff --git a/pkg/app/provider/wopi/wopi.go b/pkg/app/provider/wopi/wopi.go
@@ -151,11 +151,13 @@ func (p *wopiProvider) GetAppURL(ctx context.Context, resource *provider.Resourc
 		if u.Opaque != nil {
 			if _, ok := u.Opaque.Map["public-share-role"]; ok {
 				isPublicShare = true
+				// Makes the session anonymous
+				q.Del("userid")
 			}
 		}
 
 		if !isPublicShare {
-			q.Add("username", u.Username)
+			q.Add("username", u.DisplayName)
 		}
 	}