fix public share paths (#2580)

cs3org · Feb 23, 2022 · 863b117 · 863b117
1 parent 2056f9d
commit 863b117
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/changelog/unreleased/fix-public-share-path.md b/changelog/unreleased/fix-public-share-path.md
@@ -0,0 +1,6 @@
+Bugfix: Public shares path needs to be set
+
+We need to set the relative path to the space root for public link shares to identify them in the shares list.
+
+https://github.com/owncloud/ocis/issues/2462
+https://github.com/cs3org/reva/pull/2580
diff --git a/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go b/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go
@@ -1064,12 +1064,11 @@ func (h *Handler) addFileInfo(ctx context.Context, s *conversions.ShareData, inf
 					s.Path = strings.TrimPrefix(s.Path, h.getHomeNamespace(u))
 				}
 			}
-
-		case s.ShareType == conversions.ShareTypePublicLink:
-			s.FileTarget = path.Join("/", path.Base(info.Path))
-			s.Path = path.Join("/", path.Base(info.Path))
 		default:
 			s.FileTarget = path.Join(h.sharePrefix, path.Base(info.Path))
+			if s.ShareType == conversions.ShareTypePublicLink {
+				s.FileTarget = path.Join("/", path.Base(info.Path))
+			}
 			s.Path = info.Path
 			client, err := pool.GetGatewayServiceClient(h.gatewayAddr)
 			if err == nil {