[docs-only] added comments to detail the mapping of OCM properties #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! I would wait to merge this though, until the changes in OCM become more concrete. |
|
Agreed! |
glpatcern
force-pushed
the
ocm-comments
branch
4 times, most recently
from
ee499bb
to
352db4a
Compare
glpatcern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussions in cs3org/OCM-API#66, this is to prepare the CS3APIs so that we clarify how the OCM properties
protocol,providerIdare actually represented by the more appropriate namingprotocols,shareId, already introduced in previous PRs.Therefore this change is purely on comments. The implementation will follow in Reva.