Block device allocation configuration (bsc#937800) #487
Conversation
|
I can't reopen the original pull request as I have force-pushed to my branch since closing the or.. So the work continues here. For reference: Discussion on this change started here: #476 This change got already merged (after some more discussion) in crowbar/crowbar-openstack#39 Some background why reopening a force-pushed pull-request is not possible: |
| }, | ||
| "block_device": { | ||
| "allocate_retries": 60, | ||
| "allocate_retries_interval": 3 | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
It was not there when I commented ;-)
nkrinner
force-pushed
the
configure-disk-allocation-timeout
branch
from
dfcce86
to
8b4674f
Compare
|
+1 |
|
I'm fine with the changes, but I'd like to have the commit message updated to not reference some git id that doesn't exist (and remove the Conflicts marker). perhaps you can reference the PR from master ? |
nkrinner
force-pushed
the
configure-disk-allocation-timeout
branch
from
8b4674f
to
d6cc0d6
Compare
|
Removed the conflicts marker and the commit id, although it actually does exist: |
|
@nkrinner it does exist, but in another git repo. That's why we can't just put the commit id. I think linking to the PR would be nice. |
Make block_device_allocate_retries and block_device_allocate_retries_interval configurable from the crowbar web ui in the raw view. See also https://bugzilla.suse.com/show_bug.cgi?id=937800 (Change picked from crowbar/crowbar-openstack#39 )
nkrinner
force-pushed
the
configure-disk-allocation-timeout
branch
from
d6cc0d6
to
93158ce
Compare
|
@vuntz I understand. I had the other repo added as a remote, so git could also resolve the commit id. I now added a link to the merged pull request. |
|
No code change in the new commits, and the gating passed before commit message changed => merging. |
Block device allocation configuration (bsc#937800)
Make block_device_allocate_retries and
block_device_allocate_retries_interval configurable from
the crowbar web ui in the raw view. See also
https://bugzilla.suse.com/show_bug.cgi?id=937800
(cherry picked from commit a876afb762a5d3c52526622a4c48cb43ce410c5a)
Conflicts:
chef/data_bags/crowbar/bc-template-nova.json