Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix field comments #72

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fix field comments #72

merged 1 commit into from
Aug 15, 2022

Conversation

sergenyalcin
Copy link
Member

Description of your changes

Latest change about the API Docs causes that removing of the terrajet tag comments. This PR fixes the mentioned issue.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

make generate in provider-aws

@sergenyalcin
Fix field comments
efbd52a 
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin sergenyalcin self-assigned this Aug 15, 2022
muvaf
muvaf approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin

@muvaf muvaf merged commit a5c382c into crossplane:main Aug 15, 2022
@sergenyalcin sergenyalcin deleted the api-doc-fix branch August 15, 2022 15:44
@sergenyalcin sergenyalcin mentioned this pull request Sep 9, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muvaf muvaf muvaf approved these changes

Assignees

@sergenyalcin sergenyalcin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergenyalcin @muvaf