Swap SYNCED and READY columns in output #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
bobh66
requested review from
ulucinar,
sergenyalcin,
erhancagirici and
mergenci
as code owners
ulucinar
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks @bobh66 for the change. There's a slight possibility that there might be shell scripts that depend on the current order of the READY and SYNCED columns but I think it's better for us to align with the core Crossplane resources and I would not consider such scripts as following the best practices. I will mark the PR as breaking, treating the kubectl output as part of our contract, and it should be fine if we mention the change in the provider release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Crossplane creates CRDs for Claims and Composites with the additionalPrinterColumns "SYNCED" and "READY" in that order.
This PR modifies the code generation to use the same order of SYNCED and READY instead of the current READY and SYNCED.
Fixes #359
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Generated the Upbound provider-aws using these changes and confirmed that the CRDs were generated with the SYNCED and READY fields in that order