Don't scrape empty files #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeanduplessis
approved these changes
Sep 1, 2023
|
Thanks for the fix @marcoths. Would you mind signing the CLA so we can incorporate your change. |
|
@jeanduplessis Sure will do ASAP, thanks! |
|
@jeanduplessis I have also fixed the commit with the correct email address, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Some providers like Fastly have empty files in their docs. This PR modifies the scraper so that it won't fail trying to read empty files
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
The scraper doesn't fail when running
go run cmd/scraper/main.go -n fastly/fastly -r .work/fastly/fastly/docs/resources -o config/provider-metadata.yaml(assuming the
fastly/fastlyrepo content is already available at./.work)