Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a PlanGeneratorOption for excluding Kubernetes scenario based steps from Filesystem scenario #265

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

sergenyalcin
Copy link
Member

@sergenyalcin sergenyalcin commented Aug 28, 2023

Description of your changes

This PR:

  • Adds a PlanGeneratorOption for excluding Kubernetes scenario based steps from Filesystem scenario
  • Removes manual execution fields from plan for Filesystem source
  • Adds critical annotations to the ignore list of CopyInto function

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested in the migrator template

…d steps from Filesystem scenario

- Remove manual execution fields from plan for Filesystem source

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin sergenyalcin merged commit 14cd59c into crossplane:main Aug 31, 2023
5 checks passed
@sergenyalcin sergenyalcin deleted the fs-step-execution branch August 31, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants