Escape CEL Reserved Keywords when Generating Validation Rules #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dalton hill <dalton.hill.0@protonmail.com>
|
|
Signed-off-by: dalton hill <dalton.hill.0@protonmail.com>
dalton-hill-0
force-pushed
the
escape-cel-reserved-keywords
branch
from
1393635
to
1825930
Compare
|
PR is ready for review |
lsviben
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Minor comment, otherwise LGTM. Thanks @dalton-hill-0 for the contribution!
Signed-off-by: dalton hill <dalton.hill.0@protonmail.com>
ulucinar
reviewed
Aug 21, 2023
| @@ -444,3 +455,12 @@ func fieldPathWithWildcard(parts []string) string { | |||
| } | |||
| return seg.String() | |||
| } | |||
|
|
|||
| func sanitizePath(p string) string { | |||
There was a problem hiding this comment.
nit:
Suggested change
| func sanitizePath(p string) string { | |
| func escapeName(p string) string { |
ulucinar
reviewed
Aug 21, 2023
|
|
||
| var ( | ||
| // ref: https://github.com/google/cel-spec/blob/v0.6.0/doc/langdef.md#syntax | ||
| celReservedKeywords = []string{"true", "false", "null", "in", "as", "break", "const", "continue", |
There was a problem hiding this comment.
nit: We may use a map[string]struct{} (or the higher-level "k8s.io/apimachinery/pkg/util/sets.Set ) for O(1) lookups. Also the list we search has a relatively static small size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #254
Wraps CEL reserved keywords found in Validation Rules (i.e.,
__{keyword}__).For instance, if the object has a field "namespace", this would be the before and after in
zz_<obj>_types.goThe same diff, for the generated CRD
x-kubernetes-validations: - message: namespace is a required parameter - rule: self.managementPolicy == 'ObserveOnly' || has(self.forProvider.namespace) + rule: self.managementPolicy == 'ObserveOnly' || has(self.forProvider.__namespace__)I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested