Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config.Provider.RootGroup field docs #242

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix config.Provider.RootGroup field docs #242

merged 1 commit into from
Jul 31, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Jul 31, 2023 •
edited
Loading

Description of your changes

Fixes the config.Provider.RootGroup field docs so that it reads now as:

	// RootGroup is the root group that all CRDs groups in the provider are based
	// on, e.g. "aws.upbound.io".
	// Defaults to "<TerraformResourcePrefix>.upbound.io".

It also replaces some jet.crossplane.io with upbound.io throughout the repository.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

make reviewable

@ulucinar
Fix config.Provider.RootGroup field docs
100c7f1 
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar ulucinar mentioned this pull request Jul 31, 2023
Merged
2 tasks
haarchri
haarchri approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulucinar ulucinar merged commit b5bb513 into crossplane:main Jul 31, 2023
4 checks passed
@ulucinar ulucinar deleted the fix-docs branch July 31, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haarchri haarchri haarchri approved these changes

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulucinar @haarchri