Add support for category-based manifest pre-processors #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
lock-converters
branch
2 times, most recently
from
4bddaa0
to
c3898e0
Compare
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
…tesSource - Use the same cache dir as kubectl for migration.KubernetesSource's disk cached discovery client. - Remove all usages of meta.UnsafeGuessKindToResource. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
…ation.KubernetesSource Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
… not converted Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds support for category-based manifest pre-processors which can optionally be registered with a migration registry and are called before any converters are called. They cannot mutate resources (this is the job of converters) and they can only be used to extract information from the manifests belonging to a specific category such as the managed resources or compositions. Pre-processors can be used to initialize converters with information extracted from the manifests emitted by a source.
Following changes are also introduced in this PR:
Lock.pkgconvertersmeta.RESTMapperfor converting from GVKs to GVRs inmigration.KubernetesSourceand remove all references ofmeta.UnsafeGuessKindToResource.Configuration.metaI have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested