Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example Smaller Provider migration plan #210

Merged
merged 2 commits into from
May 29, 2023

Conversation

ezgidemirel
Copy link
Member

@ezgidemirel ezgidemirel commented May 26, 2023

Description of your changes

This change adds an example configuration migration plan and introduces Exec as a new step type. We also implement ForkExecutor to run Exec steps in our migration plan.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

With unit tests and running commands with ForkExecutor.

Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
@ezgidemirel ezgidemirel marked this pull request as ready for review May 26, 2023 16:11
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezgidemirel LGTM!

@sergenyalcin sergenyalcin merged commit f79f70f into crossplane:main May 29, 2023
@ezgidemirel ezgidemirel deleted the sp-mig-plan branch June 14, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants