Move inline bash code to separate files to prevent copy/paste errors #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
reviewed
May 17, 2023
| do | ||
| service=$(echo "${line}" | cut -d. -f1) | ||
| provider=$(echo "${line}" | cut -d. -f2) | ||
| if [[ ${provider} == "upbound" ]]; then |
There was a problem hiding this comment.
@ezgidemirel, could you make sure you took the recent changes done with #204
There was a problem hiding this comment.
thanks for the catch @turkenh, updated the script
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
ezgidemirel
force-pushed
the
move-to-scripts
branch
from
796d51a
to
b265566
Compare
turkenh
approved these changes
May 17, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Moves SP migration guide's inline bash commands to separate files.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
N/A