Consume ESS plugin changes #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezgidemirel
force-pushed
the
ess-plugin
branch
3 times, most recently
from
cd3bd4f
to
d5c8787
Compare
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
reviewed
Apr 17, 2023
|
|
||
| // ESSOptions for External Secret Stores. | ||
| type ESSOptions struct { | ||
| TLSConfig *tls.Config |
There was a problem hiding this comment.
How are we going to set the controller.Options.ESSOptions.TLSConfig? In the current implementation, the provider will panic if the --enable-external-secret-stores command-line option is passed to the provider but the ESSOptions is not set.
There was a problem hiding this comment.
We're passing the certificate path through env variable and if it's not set, we're not loading the config. You can check the PR as a reference.
There was a problem hiding this comment.
Thanks for the reference PR @ezgidemirel!
Co-authored-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This change consumes latest crossplane-runtime changes and passes TLS config to upjet based controllers.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Consumed the change in this PR and tested e2e.