Observe with Terraform Import when Observe Only #168
Conversation
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
|
Rebased on latest main. |
| // way we can do it for now. Terraform import does not return a proper exit code for this case or | ||
| // does not support -json flag to parse the returning error in a better way. | ||
| // https://github.com/hashicorp/terraform/blob/93f9cff99ffbb8d536b276a1be40a2c45ca4a67f/internal/terraform/node_resource_import.go#L235 | ||
| if strings.Contains(string(out), "Cannot import non-existent remote object") { |
There was a problem hiding this comment.
Is it possible to reliably use the Terraform state to deduce a non-existent external resource in this case?
There was a problem hiding this comment.
Probably, but I didn't feel good about reading/parsing terraform state after getting an error to my import command.
| // internal/features. This is a reasonable assumption for now | ||
| // but we may want to make it configurable in the future. | ||
| featuresPkgPath := fmt.Sprintf("%s/internal/features", pc.ModulePath) | ||
| ctrlPkgPath, err := ctrlGen.Generate(resources[name], versionGen.Package().Path(), featuresPkgPath) |
There was a problem hiding this comment.
If I understand this correctly, we will also need the upjet-based provider to supply an EnableAlphaManagementPolicies feature flag in this internal/features package looking at the changes in the controller template pkg/pipeline/templates/controller.go.tmpl.
If this is correct, we will also need a corresponding change in the template repository.
I would prefer a backward-compatible change here by defaulting to not enabling the observe-only resources feature unless a provider maintainer introduces the corresponding command-line flag & the corresponding machinery for this alpha feature to avoid confusion in those who bump their upjet versions not knowing about this change. A field in config.Provider may control this behavior (defaulting to false so that plain upjet version bumps without introducing an observe-only feature flag will not break anything). What do you think? Or do we want to force the provider maintainers to support observe-only resources in their providers when they bump their upjet versions?
There was a problem hiding this comment.
Just pushed 462dd33 for backward compatibility as you suggested.
Signed-off-by: Hasan Turken <turkenh@gmail.com>
…ility Signed-off-by: Hasan Turken <turkenh@gmail.com>
Description of your changes
This PR add support Observe Only management policy to the upjet common controller.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
By following the procedure here and observing some resources, AWS VPC, AWS EKS Cluster ...