docs: enphasize functions usage image on new resource doc #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocaneli
force-pushed
the
update-doc-2317573
branch
from
ef9e279
to
1354abd
Compare
|
@Brocaneli, thank you for your contribution. Would you mind signing the CLA so we can accept your contribution: https://cla.upbound.io/upbound/upjet |
|
After @Brocaneli signed the cla, this is ready to merge. |
|
|
Signed-off-by: Marcus Brocaneli <marcusbrocaneli@gmail.com> Author: Marcus Brocaneli <marcusbrocaneli@gmail.com> Signed-off-by: Marcus Brocaneli <marcusbrocaneli@gmail.com>
Brocaneli
force-pushed
the
update-doc-2317573
branch
from
1354abd
to
550d6d9
Compare
|
Sorry, I had commited using my corporate email, different than my Github's account, so I had to change the commit author in order to have the cla signed correctly. Would you mind reapproving this, please? |
|
@Brocaneli all good now, thank you! |
Brocaneli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR has the intention to highlight and let more visible the upjet-externalname image.
I followed the documentation a few weeks ago to create a new upjet provider based on the hashicorp vault terraform provider. I took a long time to understand how the functions for setting the external name work, and I could only make the right configuration for some Vault resources after finding the image, that I thought it was a bit hidden among all the other information. That image made the understandement of the full process that upjet follows for setting the external-name and the terraform fields, and I believe it'll be very helpful for future users to configure their providers if it's more exposed.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary. (not needed)How has this code been tested
By checking the readme file after the change