Differentiate the names of the generated conversion hub and spoke files

- Do not generate empty conversion hub or spoke files. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
crossplane · Jan 9, 2024 · 3902c69 · 3902c69
1 parent 1906bf1
commit 3902c69
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pkg/pipeline/conversion_hub.go b/pkg/pipeline/conversion_hub.go
@@ -40,7 +40,7 @@ func (cg *ConversionHubGenerator) Generate(cfgs []*terraformedInput, apiVersion
 		wrapper.WithGenStatement(GenStatement),
 		wrapper.WithHeaderPath(cg.LicenseHeaderPath),
 	)
-	filePath := filepath.Join(cg.LocalDirectoryPath, "zz_generated.conversion.go")
+	filePath := filepath.Join(cg.LocalDirectoryPath, "zz_generated.conversion_hubs.go")
 	vars := map[string]any{
 		"APIVersion": apiVersion,
 	}
@@ -55,6 +55,9 @@ func (cg *ConversionHubGenerator) Generate(cfgs []*terraformedInput, apiVersion
 		index++
 	}
 	vars["Resources"] = resources
+	if len(resources) == 0 {
+		return nil
+	}
 	return errors.Wrapf(
 		trFile.Write(filePath, vars, os.ModePerm),
 		"cannot write the generated conversion Hub functions file %s", filePath,

diff --git a/pkg/pipeline/conversion_spoke.go b/pkg/pipeline/conversion_spoke.go
@@ -61,7 +61,7 @@ func (cg *ConversionSpokeGenerator) Generate(cfgs []*terraformedInput) error { /
 			wrapper.WithGenStatement(GenStatement),
 			wrapper.WithHeaderPath(cg.LicenseHeaderPath),
 		)
-		filePath := filepath.Join(cg.LocalDirectoryPath, e.Name(), "zz_generated.conversion.go")
+		filePath := filepath.Join(cg.LocalDirectoryPath, e.Name(), "zz_generated.conversion_spokes.go")
 		vars := map[string]any{
 			"APIVersion": e.Name(),
 		}
@@ -96,6 +96,9 @@ func (cg *ConversionSpokeGenerator) Generate(cfgs []*terraformedInput) error { /
 		}
 
 		vars["Resources"] = resources
+		if len(resources) == 0 {
+			continue
+		}
 		if err := trFile.Write(filePath, vars, os.ModePerm); err != nil {
 			return errors.Wrapf(err, "cannot write the generated conversion Hub functions file %s", filePath)
 		}