Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EC2 Fleet example to use most recent LaunchTemplate version #1457

Conversation

teabot
Copy link
Contributor

@teabot teabot commented Aug 12, 2024

Description of your changes

Updated the ec2_fleet example to use the more recent v1beta2 companion ec2_launch_template. Additionally fixed some formatting issues in the example that had caused some 'missing property' warnings.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

uptest

export UPTEST_EXAMPLE_LIST=examples/ec2/v1beta1/fleet.yaml
make e2e

Result:

--- PASS: kuttl (72.98s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (72.20s)

@teabot teabot force-pushed the fix/update-ec2-fleet-launch-template-version branch from 776556f to a7113f6 Compare August 12, 2024 14:51
@teabot teabot marked this pull request as ready for review August 12, 2024 14:51
Signed-off-by: Elliot West <elliot.west@dremio.com>
@teabot teabot force-pushed the fix/update-ec2-fleet-launch-template-version branch from a7113f6 to b10f89c Compare August 15, 2024 10:01
@turkenf
Copy link
Collaborator

turkenf commented Aug 19, 2024

/test-examples="examples/ec2/v1beta1/fleet.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @teabot, LGTM.

@turkenf turkenf merged commit 4485b44 into crossplane-contrib:main Aug 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants