Revert upjet changes around calculating instance diff in 0.47 #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/elasticache/replicationgroup.yaml" |
3 tasks
|
/test-examples="examples/elasticache/replicationgroup.yaml" |
mbbush
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
@erhancagirici @turkenf Is this something that you think we can get addressed for the next release? I'd really like to either fix it in 0.47 with a patch release or confirm the replicationgroup is working in 0.48 (or whatever the next release is going to be) |
|
@mbbush crossplane/upjet#337 addressed the root cause, and #1086 consumed the upjet fix. These will be available at |
|
Thanks @erhancagirici, that's great news! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This rolls back the upjet version in the provider-aws release-0.47 branch to resolve errors thrown when calculating instance diffs.
Somewhere in crossplane/upjet#317, crossplane/upjet#319 and/or crossplane/upjet#324 there was a change introduced in upjet related to calculating terraform instance diffs, that was included in provider-aws 0.47.0, and which seems to be the cause of errors relating to nil/zero values on several different resources.
Unfortunately, a linear revert to an earlier commit in the
mainbranch on upjet won't work, because there was a forwards-incompatible schema change that would be a breaking change to revert (and is unrelated to this issue).I opened crossplane/upjet#333, to roll back upjet to that commit, and then built this off of that revision.
Fixes #1071
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Uptest