Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channel: discard messages eagerly #669

Merged
merged 3 commits into from
Mar 26, 2021
Merged

channel: discard messages eagerly #669

merged 3 commits into from
Mar 26, 2021

Conversation

BusyJay
Copy link
Contributor

@BusyJay BusyJay commented Feb 28, 2021

If all receivers are dropped, the memory hold by channel will only be
dropped when all senders are also dropped. If there are too many
channels the memory leak can be significant.

@BusyJay
channel: discard messages eagerly
49188f7 
If all receivers are dropped, the memory hold by channel will only be
dropped when all senders are also dropped. If there are too many
channels the memory leak can be significant.

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
make clippy happy
f28ea86 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
wait at boundary
f0e414d 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
taiki-e
taiki-e approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 26, 2021

Build succeeded:

@bors bors bot merged commit 06d77d3 into crossbeam-rs:master Mar 26, 2021
@BusyJay BusyJay deleted the discard-messages-eargerly branch March 26, 2021 13:22
@BusyJay BusyJay mentioned this pull request Mar 29, 2021
Merged
@taiki-e taiki-e mentioned this pull request Apr 10, 2021
Merged
bors bot added a commit that referenced this pull request Apr 10, 2021
@bors @taiki-e
Merge #683
b13fdee 
683: Prepare for the next release r=taiki-e a=taiki-e

Changes:

- crossbeam-channel 0.5.0 -> 0.5.1
  - Fix memory leak in unbounded channel. (#669)


Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e
Copy link
Member

taiki-e commented Apr 10, 2021

Published in crossbeam-channel 0.5.1

@taiki-e taiki-e mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
crossbeam-channel
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BusyJay @taiki-e