Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests for kustomize patches support #21

Merged
merged 5 commits into from
Sep 21, 2023
Merged

fix: tests for kustomize patches support #21

merged 5 commits into from
Sep 21, 2023

Conversation

sourceful-karlson
Copy link

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@sourceful-karlson sourceful-karlson changed the base branch from master to kustomize-patches-support September 21, 2023 09:51
@sourceful-karlson sourceful-karlson changed the title Test/kustomize patches support fix: tests for kustomize patches support Sep 21, 2023
@sourceful-karlson sourceful-karlson marked this pull request as ready for review September 21, 2023 13:33
@sourceful-karlson
Copy link
Author

@crenshaw-dev any good ideas or other tests cases that I need to add?

@crenshaw-dev crenshaw-dev merged commit 9d102a6 into crenshaw-dev:kustomize-patches-support Sep 21, 2023
1 check passed
@crenshaw-dev
Copy link
Owner

Nope, I think this is probably solid. It's a simple feature, thankfully. Thanks for the code!

crenshaw-dev added a commit that referenced this pull request Sep 21, 2023
@crenshaw-dev
feat(kustomize): add patches field (argoproj#5114)
5e811aa 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

feat(kustomize): update kustomize docs (#20)

* feat(kustomize): update kustomize docs

Signed-off-by: arlan lloyd <arlanlloyd@gmail.com>

* feat(kustomize): update kustomize docs

Signed-off-by: arlan lloyd <arlanlloyd@gmail.com>

* Update docs/user-guide/kustomize.md

---------

Signed-off-by: arlan lloyd <arlanlloyd@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

fix: tests for kustomize patches support (#21)

* add tables

* ci: add applicationset argocd

* ci: add applicationset argocd

* ci: add applicationset argocd

* ci: add applicationset argocd

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourceful-karlson @crenshaw-dev