move settings fetch outside loop

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

util/argo/argo.go

@@ -579,6 +579,15 @@ func verifyGenerateManifests(
 			Message: errDestinationMissing,
 		})
 	}
+	// If source is Kustomize add build options
+	kustomizeSettings, err := settingsMgr.GetKustomizeSettings()
+	if err != nil {
+		conditions = append(conditions, argoappv1.ApplicationCondition{
+			Type:    argoappv1.ApplicationConditionInvalidSpecError,
+			Message: fmt.Sprintf("Error getting Kustomize settings: %v", err),
+		})
+		return conditions // Can't perform the next check without settings.
+	}
 
 	for _, source := range sources {
 		repoRes, err := db.GetRepository(ctx, source.RepoURL)
@@ -589,15 +598,6 @@ func verifyGenerateManifests(
 			})
 			continue
 		}
-		// If source is Kustomize add build options
-		kustomizeSettings, err := settingsMgr.GetKustomizeSettings()
-		if err != nil {
-			conditions = append(conditions, argoappv1.ApplicationCondition{
-				Type:    argoappv1.ApplicationConditionInvalidSpecError,
-				Message: fmt.Sprintf("Error getting Kustomize settings: %v", err),
-			})
-			continue
-		}
 		kustomizeOptions, err := kustomizeSettings.GetOptions(source)
 		if err != nil {
 			conditions = append(conditions, argoappv1.ApplicationCondition{