Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): User file types override default file types #756

Merged
merged 2 commits into from
Jun 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions crates/typos-cli/src/file_type.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use kstring::KString;

#[derive(Default, Clone, Debug)]
pub struct TypesBuilder {
definitions: BTreeMap<KString, Vec<KString>>,
definitions: BTreeMap<KString, Vec<(KString, usize)>>,
}

impl TypesBuilder {
Expand All @@ -18,7 +18,7 @@ impl TypesBuilder {
.iter()
.map(|(name, glob)| {
let name = KString::from(*name);
let globs = glob.iter().map(|s| KString::from(*s)).collect();
let globs = glob.iter().map(|s| (KString::from(*s), 0)).collect();
(name, globs)
}),
);
Expand All @@ -31,25 +31,41 @@ impl TypesBuilder {
pub fn add(&mut self, name: impl Into<KString>, glob: impl Into<KString>) {
let name = name.into();
let glob = glob.into();
self.definitions.entry(name).or_default().push(glob);
let weight = self.definitions.len();
self.definitions
.entry(name)
.or_default()
.push((glob, weight));
}

pub fn build(self) -> Result<Types, anyhow::Error> {
let mut definitions = self
.definitions
.iter()
.flat_map(|(name, globs)| {
globs.iter().map(move |glob| {
globs.iter().map(move |(glob, weight)| {
let sort = sort_key(glob);
(sort, name, glob)
(sort, weight, name, glob)
})
})
.collect::<Vec<_>>();
definitions.sort();

let rev_definitions = definitions
.iter()
.map(|(_, _, name, glob)| (*glob, *name))
.collect::<BTreeMap<_, _>>();
let mut unique_definitions = BTreeMap::<KString, Vec<KString>>::new();
for (glob, name) in rev_definitions {
unique_definitions
.entry(name.clone())
.or_default()
.push(glob.clone());
}

let mut glob_to_name = Vec::new();
let mut build_set = globset::GlobSetBuilder::new();
for (_, name, glob) in definitions {
for (_, _, name, glob) in definitions {
glob_to_name.push(name.clone());
build_set.add(
globset::GlobBuilder::new(glob)
Expand All @@ -60,7 +76,7 @@ impl TypesBuilder {
let set = build_set.build()?;

Ok(Types {
definitions: self.definitions,
definitions: unique_definitions,
glob_to_name,
set,
matches: std::sync::Arc::new(thread_local::ThreadLocal::default()),
Expand Down
11 changes: 11 additions & 0 deletions crates/typos-cli/tests/cmd/override-default-type.in/_typos.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
[type.asc] # GPG keys
extend-glob = ["*.asc"]
check-file = false

[default.extend-words]
foo = "bar"

[files]
extend-exclude = [
"_typos.toml"
]
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
foo
11 changes: 11 additions & 0 deletions crates/typos-cli/tests/cmd/override-default-type.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
bin.name = "typos"
args = "--file-types"
status.code = 0
stdin = '''
\n\n
Destory
'''
stdout = """
./key.asc:asc
"""
stderr = ""
Loading