Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dict): Add suggestions "greater" and "gather" for the typo "grather" #1093

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Sep 1, 2024

Sorry, I might have written a wrongly formatted request for multiple candidates.

grather -> greater|gather

Typos now detect it as a disallowed word. I don't have confidence that this is valid or invalid because this pattern is not found for other entries.

Current

> cargo test --workspace --no-run

> echo 'grather' | ./target/debug/typos --version -
typos-cli 1.24.3

> echo 'grather' | ./target/debug/typos -
error: `grather` is disallowed
  --> -:1:1
  |
1 | grather
  | ^^^^^^^
  |

After this change

> echo 'grather' | ./target/debug/typos -
error: `grather` should be `greater`, `gather`
  --> -:1:1
  |
1 | grather
  | ^^^^^^^
  |

@coveralls
Copy link

coveralls commented Sep 1, 2024

Pull Request Test Coverage Report for Build 10652834915

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.9%

Totals Coverage Status
Change from base Build 10639154778: 0.0%
Covered Lines: 537
Relevant Lines: 2345

💛 - Coveralls

"greater" and "gather" will be the candidates
@epage epage merged commit 39f678e into crate-ci:master Sep 3, 2024
17 checks passed
@kachick
Copy link
Contributor Author

kachick commented Sep 4, 2024

Thank you for merging!

@kachick kachick deleted the grather-suggest-candidates branch September 4, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants