Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- changes to work with V3 Arduino #2146

Closed
wants to merge 1 commit into from

Conversation

sirpete83
Copy link

No description provided.

@NiKiZe
Copy link
Collaborator

NiKiZe commented Sep 11, 2024

This looks as a duplicate of #2040 and #2144

This PR has several linter issues that would be easy to adress.

But I would also like to see an explanation to as to what this PR does better than the other ones.

@Buddy-Matt
Copy link

@NiKiZe - #2040 wasn't working for me (see comment there). Both this PR and #2144 are able to decode my remote. This one feels slightly more accurate and less prone to false readings than the other, but that's on a sample of one device (M5Stack NanoC6 / Arduino IDE) so not particularly scientific I'm afraid.

@NiKiZe
Copy link
Collaborator

NiKiZe commented Sep 23, 2024

This PR has breaking changes and some other issues, I think that #2144 is a better first step.
If there anything in this PR that would be better than #2144 I would happy to re-open and coach to get this PR to be in a mergable state, but that will require some communication and back and forth, closing for now.

@NiKiZe NiKiZe closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants