fix: Handle undefined this.konnector for OAuth connectors #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ConnectionFlow, this.konnector is undefined. I don't see any justification for that but it won't have any other nagative effect on the connector exection. This causes a fatal error on all applications using harvest and trying to configure an OAuth connector This is a hotfix. We will check why this variable is undefined in later investigation
Crash--
approved these changes
Nov 22, 2021
doubleface
pushed a commit
to cozy/cozy-home
that referenced
this pull request
Nov 22, 2021
Upgrade cozy-harvest-lib to 6.14.2 to avoid a fatal error on account creation for OAuth connectors cozy/cozy-libs#1390
doubleface
pushed a commit
to cozy/cozy-home
that referenced
this pull request
Nov 22, 2021
Upgrade cozy-harvest-lib to 6.14.2 to avoid a fatal error on account creation for OAuth connectors cozy/cozy-libs#1390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ConnectionFlow, this.konnector can be undefined.
I don't see any justification for that but it won't have any
other nagative effect on the connector exection.
This causes a fatal error on all applications using
harvest and trying to configure an OAuth connector
This is a hotfix.
We will check why this variable is undefined in later investigation