Add construct() methods to specify the milliseconds being used for time-based UUID generation
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed UUID generation. This is useful for migrating existing sets of data which include a timestamp, but don't use ordered UUID values.
cowtowncoder
approved these changes
Sep 8, 2023
cowtowncoder
changed the title
cowtowncoder
reviewed
Sep 8, 2023
| return generate(_clock.currentTimeMillis()); | ||
| } | ||
|
|
||
| public UUID generate(long rawTimestamp) |
There was a problem hiding this comment.
Let's rename this as construct(), since it's not fully generating any more.
Also add Javadoc with @since 4.3 to indicate addition.
cowtowncoder
reviewed
Sep 8, 2023
| return generate(rawTimestamp); | ||
| } | ||
|
|
||
| public UUID generate(long rawTimestamp) |
There was a problem hiding this comment.
Same here as above.
Plus can avoid assignment and just call construct(_timer.getTimestamp());
|
Ok, aside from 2 comments one missing thing: With those I'm happy to merge this! |
- add @SInCE in javadoc - rename generate to construct - include new api in TimeBasedReorderedGenerator
|
Have made updates based on PR review. |
cowtowncoder
approved these changes
Sep 12, 2023
cowtowncoder
changed the title
construct() methods to specify the milliseconds being used for time-based UUID generation
cowtowncoder
added a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for migrating existing sets of data which include a timestamp, but don't use ordered UUID values.