Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timeout setting #456

Merged
merged 4 commits into from
Mar 16, 2021
Merged

fix timeout setting #456

merged 4 commits into from
Mar 16, 2021

Conversation

colin-axner
Copy link
Contributor

No description provided.

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I wonder how we can introduce more robust testing for the relayer in the future

@colin-axner
Copy link
Contributor Author

ACK. I wonder how we can introduce more robust testing for the relayer in the future

Adding more tests, I don't know if we test timeouts. I'm sure there could also be some testing framework where a relayer connects to 2 chains and attempts to relay all the events and the test checks if all the state changes match the expected ones (returning errors if the relayer missed events etc)

@colin-axner colin-axner merged commit 2a2dd3b into master Mar 16, 2021
@colin-axner colin-axner deleted the colin/fix-timeouts branch March 16, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants