Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rly tx channel deprecated #410

Merged
merged 6 commits into from
Feb 5, 2021

Conversation

NagaTulasi
Copy link
Contributor

No description provided.

@NagaTulasi NagaTulasi marked this pull request as ready for review February 5, 2021 08:23
@NagaTulasi
Copy link
Contributor Author

Hi @colin-axner, can you please review this PR and let me know if there are any changes

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @NagaTulasi for looking into this.

Lets remove all this code/this command (so we don't need to maintain it) and add the alias channel to the transaction link cmd. Since that command should be a duplicate of this one

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Always love deleting code. Thanks!

@colin-axner colin-axner merged commit 9f13a93 into cosmos:master Feb 5, 2021
@NagaTulasi NagaTulasi deleted the rly-tx-channel-deprecated branch February 6, 2021 05:29
@NagaTulasi NagaTulasi restored the rly-tx-channel-deprecated branch February 6, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants