Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ICS-29 guide to path docs #1375

Merged
merged 4 commits into from
Jan 9, 2024
Merged

add ICS-29 guide to path docs #1375

merged 4 commits into from
Jan 9, 2024

Conversation

ertemann
Copy link
Contributor

No description provided.

Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, just had one request then we can get this merged!

<br>
<br>

One can add the ` --version "{\"fee_version\":\"ics29-1\",\"app_version\":\"ics20-1\"}" ` flag to the `link` transaction in order to create a channel that supports the [ICS-29](https://github.com/cosmos/ibc/issues/578) fee protocol standard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the hyperlink to reference the ics-29 spec instead of the pr?
https://github.com/cosmos/ibc/tree/main/spec/app/ics-029-fee-payment

Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@jtieri jtieri merged commit 3b05fdb into cosmos:main Jan 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants