Bring in key management, tx broadcasting, and configuration logic from lens #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
requested review from
jackzampolin,
boojamya and
mark-rushakoff
as code owners
agouin
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back all of the key management, tx broadcasting, and configuration logic from
lens. With this we are like 80% of the way to completely removinglensas a dependency in the relayer. I will open a follow up PR that brings in the chain registry logic, which should be the only piece we are missing now.I tried to keep the PRs small but gutting the config from
lensin the relayer required also removing thelens.ChainClientwhich meant bringing back in theKeyProviderimplementation and the missing methods related to tx broadcasting from theChainProvider