Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get-gaia command in Makefile used repo variable as branch #1070

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix: get-gaia command in Makefile used repo variable as branch #1070

merged 1 commit into from
Jan 17, 2023

Conversation

MalteHerrmann
Copy link
Contributor

make get-gaia tries to clone a branch from the Gaia repository, which corresponds to the version defined at the top of the Makefile.

The specified branch however used the GAIA_REPO variable instead of GAIA_VERSION, which is fixed in this PR.

@MalteHerrmann MalteHerrmann mentioned this pull request Jan 13, 2023
Merged
boojamya
boojamya approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@boojamya boojamya merged commit 0388485 into cosmos:main Jan 17, 2023
@MalteHerrmann MalteHerrmann deleted the fix-get-gaia branch January 18, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojamya boojamya boojamya approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@jtieri jtieri Awaiting requested review from jtieri

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MalteHerrmann @boojamya