Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new clients-expiration query returning time before expiration #1027

Merged
merged 1 commit into from
Nov 1, 2022
Merged

feat: add new clients-expiration query returning time before expiration #1027

merged 1 commit into from
Nov 1, 2022

Conversation

glebiller
Copy link
Contributor

It's currently not simple to get the time left before an IBC light client expires.

This PR adds a new query clients-expiration path that will check the state of the light client and return the duration before it expires.

$ rly query clients-expiration cosmoshub-irisnet
  client 07-tendermint-384 (cosmoshub-4) expires in 306h0m0s (08 Nov 22 10:05 UTC)
  client 07-tendermint-31 (irishub-1) expires in 307h0m0s (08 Nov 22 11:08 UTC)

boojamya
boojamya reviewed Oct 26, 2022
View reviewed changes
relayer/query.go Outdated Show resolved Hide resolved
cmd/query.go Outdated Show resolved Hide resolved
relayer/query.go Outdated Show resolved Hide resolved
@boojamya
Copy link
Contributor

Nice, thanks for this addition @glebiller!

@glebiller
Copy link
Contributor Author

Improved according to @boojamya feedback :)

boojamya
boojamya reviewed Oct 28, 2022
View reviewed changes
relayer/query.go Outdated Show resolved Hide resolved
@boojamya boojamya merged commit b88f24b into cosmos:main Nov 1, 2022
agouin pushed a commit that referenced this pull request Nov 15, 2022
@glebiller @agouin
feat: add new clients-expiration query returning time before expirati…
3198e29 
…on (#1027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojamya boojamya boojamya approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@jtieri jtieri Awaiting requested review from jtieri

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glebiller @boojamya