Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix collect gentxs for provider app #926

Merged

Conversation

sontrinh16
Copy link
Member

@sontrinh16 sontrinh16 commented May 8, 2023

Description

Follow sdk 47 codebase in create a new genutil AppModule to fix the issue of unable to execute collect-gentxs correctly in e2e testing


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@faddat
Copy link
Contributor

faddat commented May 8, 2023

NIIIIICE

@MSalopek
Copy link
Contributor

MSalopek commented May 9, 2023

Awesome, this fixes the issue and allows e2e to run.

Thank you @sontrinh16!

@MSalopek MSalopek merged commit d7e271f into cosmos:upgrade-47-with-fixes May 9, 2023
@sontrinh16 sontrinh16 deleted the fix_collect_gentx branch May 9, 2023 14:13
This was linked to issues May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update provider to SDK 0.47 Upgrade e2e tests to SDK 0.47
3 participants