Proto compilation fixes #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Path facilities to compose paths as PathBuf objects rather than cycling the representation through strings with potential garbling in `.display()`.
|
I have verified the changes by running |
Use a single distinctive subdirectory under ~/.cache to house all checkouts for the build script, as per the XDG convention.
mzabaluev
force-pushed
the
mikhail/proto-paths
branch
from
888ebc5
to
384ba58
Compare
romac
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple minor fixes to the code generation infrastructure:
Don't format
Pathinto (potentially garbled) strings to compose new paths. There is aPath-native API for that. The resulting code is also less crufty.Use a single distinctive subdirectory under
~/.cacheto house allcheckouts for the build script, as per the XDG convention.