ADR 002: importing multiple ibc-go versions #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
changed the title
crodriguezvega
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Nice explanation! I left my usual nitpicking comments... 🔎 Just two things that maybe should change in the whole document:
- I think Go (with uppercase) is the official name, so maybe we should be consistent.
- Instead of just saying SDK, should we always say Cosmos SDK? To be more specific, just in case.
damiannolan
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Ack. Agree with suggestions from @crodriguezvega. Nice work!
Co-authored-by: Carlos Rodriguez <crodveg@yahoo.es>
colin-axner
requested review from
AdityaSripal,
charleenfei and
seantking
as code owners
seantking
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Covers the thought process for deciding not to support importing multiple ibc-go versions
content comes from previous comments from myself and @damiannolan
closes: #632
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes