Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] ICS20-V2 #6352
[FEAT] ICS20-V2 #6352
Changes from 23 commits
c07bca9
e66bd89
034f472
4cc6a85
71f830c
28ff9b6
4e55137
ca056cf
147cf17
9bbfa1a
4f57916
4c333c5
0478cb9
f39d173
9b39944
06ca9a5
7897ef3
786a4f1
5747756
7e2e6df
a84b0e7
43877df
8eae033
dbcff45
bb69698
f19a145
8f86dda
d4b06c8
a9391a4
575403e
50ccd94
87eb32e
e8b9d5a
6d40bc6
c171059
9890f53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper error handling for invalid packet data.
The test for invalid packet data correctly checks for an error, which is good practice. However, it would be beneficial to assert the type of error to ensure that it is specifically related to packet data unmarshalling. This can help identify if the correct error handling paths are being triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper error handling when the underlying app does not support packet data unmarshaling.
The error message in
UnmarshalPacketData
should provide more context about the failure, including the port and channel IDs involved, to aid in debugging.Committable suggestion