Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable wasm lint/build/test on every PR and push to main. #5879

Merged
merged 2 commits into from
Feb 21, 2024
Merged

ci: enable wasm lint/build/test on every PR and push to main. #5879

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db2d064
ci: enable wasm lint/build/test on every PR and push to main.
DimitrisJim Feb 20, 2024
d2a4d3f
Merge branch 'main' into jim/enable-wasm-tests
DimitrisJim Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/wasm-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ name: Wasm Light-Client
# This workflow runs when a PR is opened that targets code that is part of the wasm light-client.
on:
pull_request:
paths:
- '.github/workflows/wasm-client.yml'
- 'modules/light-clients/08-wasm/**'
- 'proto/ibc/lightclients/wasm/**'
push:
branches:
main
Comment on lines +5 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to run them again on merge to main? The code on the PR should already be synced with main when they're running on the PR right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea should be redundant, can't think of a case where it wouldn't (maybe auto merge?).

Looking at our other workflows (callbacks and main ibc-go one), we do run em in so I'll just push this with it for now and we can drop em all at some point.

permissions:
contents: read

Expand Down
Loading