Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msg): register proto interface #5839

Closed
wants to merge 1 commit into from
Closed

Conversation

emidev98
Copy link
Contributor

Register the proto interfaces for InterchainAccounts, that way when submitting a transaction and it responds with MsgRegisterInterchainAccountResponse or MsgSendTxResponse it does not fail with the following error:

image

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emidev98! I'm getting déjà vu though #4944, I'm wondering how this slipped out of the main branch (I guess through merge conflict?) and I'm wondering if we can add a test for it? cc @damiannolan

@colin-axner
Copy link
Contributor

colin-axner commented Feb 14, 2024

Now I'm very confused, I see it on main?

msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)

@colin-axner
Copy link
Contributor

ah looks like the branch opened is out of date! Looks like we can close this?

@emidev98
Copy link
Contributor Author

Thanks for the review, if you feel like this is not needed anymore we can proceed to close this one.
When do you think this changes will be available for a v7 release?

@crodriguezvega
Copy link
Contributor

Thanks for the review, if you feel like this is not needed anymore we can proceed to close this one.
When do you think this changes will be available for a v7 release?

We released this in v7.3.2 (see changelog here). I will then close the PR. Thank you, @emidev98!

@emidev98
Copy link
Contributor Author

Oh I see! Thank you for the release and the mention! Have a very good day and sorry for the confusion! 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants