fix: guarentee proof availiability for channel upgrades #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andle edge case of counterparty initiating upgrade in the same block
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5638 +/- ##
==========================================
+ Coverage 81.18% 81.21% +0.03%
==========================================
Files 199 199
Lines 15289 15294 +5
==========================================
+ Hits 12412 12421 +9
+ Misses 2408 2404 -4
Partials 469 469
|
colin-axner
added
priority
There was a problem hiding this comment.
Great work figuring out this edge case, @colin-axner. Just had a quick, first look.
colin-axner
requested review from
AdityaSripal,
charleenfei,
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
AdityaSripal
approved these changes
Jan 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
* fix: add counterparty upgrade sequence to MsgChannelUpgradeOpen and handle edge case of counterparty initiating upgrade in the same block * docs: add sufficient documentation for accidental breakage in the opening handshake * lint lint lint * test: add additional test case * fix: proto numbering * change error message --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit f67d60b) # Conflicts: # docs/docs/01-ibc/06-channel-upgrades.md
crodriguezvega
added a commit
that referenced
this pull request
Jan 24, 2024
…) (#5697) * fix: guarentee proof availiability for channel upgrades (#5638) * fix: add counterparty upgrade sequence to MsgChannelUpgradeOpen and handle edge case of counterparty initiating upgrade in the same block * docs: add sufficient documentation for accidental breakage in the opening handshake * lint lint lint * test: add additional test case * fix: proto numbering * change error message --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit f67d60b) # Conflicts: # docs/docs/01-ibc/06-channel-upgrades.md * fix conflict * remove docs --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
requires updated handling in hermes
closes: #3930
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.