Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IBCClientHeader func for endpoint and update tests #5493

Merged

Conversation

expertdicer
Copy link
Contributor

Description

closes: #4003

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@expertdicer expertdicer marked this pull request as ready for review December 25, 2023 02:13
@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Jan 15, 2024
@DimitrisJim
Copy link
Contributor

heyo @expertdicer, sorry for delay, we discussed this last week and Colin left a comment on the issue w.r.t how we want to add this, should be minor tweaks!

Let us know if you want us to push these final changes, thanks again!

@DimitrisJim DimitrisJim added the testing Testing package and unit/integration tests label Jan 24, 2024
@colin-axner
Copy link
Contributor

colin-axner commented Jan 25, 2024

I can push the changes next week if you don't get a chance before then (converting to draft for now)

@colin-axner colin-axner marked this pull request as draft January 25, 2024 11:56
@colin-axner colin-axner removed the priority PRs that need prompt reviews label Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1c0c756) 81.59% compared to head (ace9423) 81.54%.
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5493      +/-   ##
==========================================
- Coverage   81.59%   81.54%   -0.05%     
==========================================
  Files         199      199              
  Lines       15167    12079    -3088     
==========================================
- Hits        12375     9850    -2525     
+ Misses       2326     1764     -562     
+ Partials      466      465       -1     
Files Coverage Δ
...interchain-accounts/controller/keeper/handshake.go 84.15% <100.00%> (+0.45%) ⬆️
...ules/apps/27-interchain-accounts/types/metadata.go 81.01% <100.00%> (+1.21%) ⬆️
modules/apps/transfer/types/codec.go 100.00% <ø> (+13.79%) ⬆️
modules/core/03-connection/keeper/verify.go 83.63% <100.00%> (+3.27%) ⬆️
modules/core/03-connection/types/connection.go 100.00% <ø> (+10.16%) ⬆️
modules/core/04-channel/keeper/handshake.go 90.22% <100.00%> (+0.01%) ⬆️
modules/core/04-channel/keeper/timeout.go 95.15% <100.00%> (-0.25%) ⬇️
modules/core/04-channel/keeper/upgrade.go 92.06% <100.00%> (-0.41%) ⬇️
modules/apps/transfer/keeper/relay.go 90.32% <60.00%> (-0.62%) ⬇️
modules/apps/transfer/types/packet.go 88.88% <50.00%> (-3.80%) ⬇️
... and 1 more

... and 160 files with indirect coverage changes

@crodriguezvega crodriguezvega marked this pull request as ready for review February 2, 2024 14:45

// IBCClientHeader will construct a 07-tendermint Header to update the light client
// on the counterparty chain. The trustedHeight must be passed in as a non-zero height.
func (chain *TestChain) IBCClientHeader(header *ibctm.Header, trustedHeight clienttypes.Height) (*ibctm.Header, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that we don't currently store historical headers (we only keep the latest committed header), we could drop the header arg and assume that. But fine as is, might be more flexible for future testing scenarios

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@colin-axner
Copy link
Contributor

Thanks @crodriguezvega for applying the changes!

@colin-axner colin-axner changed the title add PopulateClientHeader func for endpoint and update tests add IBCClientHeader func for endpoint and update tests Feb 6, 2024
@crodriguezvega crodriguezvega merged commit 99202e6 into cosmos:main Feb 6, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing package and unit/integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PopulateClientHeader to testing pkg
5 participants