-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add IBCClientHeader func for endpoint and update tests #5493
add IBCClientHeader func for endpoint and update tests #5493
Conversation
# Conflicts: # testing/chain.go
heyo @expertdicer, sorry for delay, we discussed this last week and Colin left a comment on the issue w.r.t how we want to add this, should be minor tweaks! Let us know if you want us to push these final changes, thanks again! |
I can push the changes next week if you don't get a chance before then (converting to draft for now) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5493 +/- ##
==========================================
- Coverage 81.59% 81.54% -0.05%
==========================================
Files 199 199
Lines 15167 12079 -3088
==========================================
- Hits 12375 9850 -2525
+ Misses 2326 1764 -562
+ Partials 466 465 -1
|
|
||
// IBCClientHeader will construct a 07-tendermint Header to update the light client | ||
// on the counterparty chain. The trustedHeight must be passed in as a non-zero height. | ||
func (chain *TestChain) IBCClientHeader(header *ibctm.Header, trustedHeight clienttypes.Height) (*ibctm.Header, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that we don't currently store historical headers (we only keep the latest committed header), we could drop the header arg and assume that. But fine as is, might be more flexible for future testing scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thanks @crodriguezvega for applying the changes! |
Description
closes: #4003
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.