Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding changelog to mod/capability #4627

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

damiannolan
Copy link
Member

Description

Adds a basic changelog to mod/capability


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan added the capability Issues for capability modules label Sep 12, 2023
@damiannolan
Copy link
Member Author

Note, I've omitted #4557 from the changelog as this fix is not a diff between versions, more so something that was missed in the sdk upgrade. I can include it if people feel its necessary.

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one typo

modules/capability/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Cian Hatton <cian@interchain.io>
@damiannolan damiannolan enabled auto-merge (squash) September 12, 2023 14:23
@damiannolan damiannolan merged commit 20b52cc into main Sep 12, 2023
18 of 19 checks passed
@damiannolan damiannolan deleted the damian/add-capability-changelog branch September 12, 2023 14:42
mergify bot pushed a commit that referenced this pull request Sep 12, 2023
* chore: adding changelog to mod/capability

* Update modules/capability/CHANGELOG.md

Co-authored-by: Cian Hatton <cian@interchain.io>

---------

Co-authored-by: Cian Hatton <cian@interchain.io>
(cherry picked from commit 20b52cc)
crodriguezvega pushed a commit that referenced this pull request Sep 13, 2023
* chore: adding changelog to mod/capability (#4627)

* chore: adding changelog to mod/capability

* Update modules/capability/CHANGELOG.md

Co-authored-by: Cian Hatton <cian@interchain.io>

---------

Co-authored-by: Cian Hatton <cian@interchain.io>
(cherry picked from commit 20b52cc)

* docs: fixed broken links (#4571)

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-capability-to-v1.0.x capability Issues for capability modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants