add cli for MsgIBCSoftwareUpgrade #4558

charleenfei · 2023-09-04T15:57:44Z

Description

closes: #3673

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md).
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards and Go style guide.
Wrote unit and integration tests.
Updated relevant documentation (docs/) or specification (x/<module>/spec/).
Added relevant godoc comments.
Provide a commit message to be used for the changelog entry in the PR description for review.
Re-reviewed Files changed in the Github PR explorer.
Review Codecov Report in the comment section below once CI passes.

charleenfei · 2023-09-04T15:57:58Z

modules/core/02-client/client/cli/tx.go

@@ -294,10 +294,6 @@ func NewCmdSubmitRecoverClientProposal() *cobra.Command {

 	flags.AddTxFlagsToCmd(cmd)
 	govcli.AddGovPropFlagsToCmd(cmd)
-	err := cmd.MarkFlagRequired(govcli.FlagTitle)
-	if err != nil {


i think this was deprecated in govv1

Sorry, just looking at this again. Where did you see that was not needed? I see that CLIs in SDK still do this (here and here).

i saw it here

since we were targetting sdk 47.5 with this feature branch initially, but now i do see in sdk 50 it seems to be undeprecated...?

aha! @julienrbrt explains: In v0.46 with the introduction to gov v1 these were deprecated. However in v0.47+ we've reintroduced title and summary in the proposal (instead of only in the metadata), hence the un-deprecation.

i can update this :)

crodriguezvega

Looks good! Just left a few nits.

modules/core/02-client/client/cli/tx.go

damiannolan

Looks good to me. Did you test this manually?

modules/core/02-client/client/cli/cli.go

chatton

Looks great! Just had a few suggestions for some small improvements.

modules/core/02-client/client/cli/tx.go

DimitrisJim · 2023-09-06T06:11:23Z

modules/core/02-client/client/cli/tx.go

+	cmd.Flags().String(FlagAuthority, "", "The address of the client module authority (defaults to gov)")
+
+	flags.AddTxFlagsToCmd(cmd)
+	govcli.AddGovPropFlagsToCmd(cmd)


needing to mark title as required here too yea?

yea, there was some confusion on this, see above conversation, but now clear and I can add em back :)

…and `MsgIBCSoftwareUpgrade`. The legacy proposal types `ClientUpdateProposal` and `UpgradeClientProposal` have been removed. (#4620) * Add proto message, implement sdk.Msg for Recover Client. (#4494) * Add proto message for Recover client, implement sdk.Message interface. * Update modules/core/02-client/types/msgs.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Apply suggestions from code review Co-authored-by: Charly <charly@interchain.io> * Remove gogoproto false for cmp, lint, move ibctesting address inline. --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Charly <charly@interchain.io> * add protos, msgs, keeper handler to upgrade clients using v1 governance proposals (#4436) * add protos and keeper function placeholder * add keeper functions/tests, msgs and tests * update to 0.47.5 release branch * Move signer as last proto field. (#4510) * msg server function and tests for MsgScheduleIBCClientUpgrade (#4442) * Add 02-client implementation for Recover client. (#4499) * Add 02-client implementation for Recover client. * Partially address feedback. * Docu RecoverClient, add label, re-use error. * Add implementation for recover client on message server. (#4503) * Add message server handler for recovering a client * Don't assign to deprecated attrs, clean up unused fields. * Further clean-up, remove declaration of unmutated vars. * Add cmd for submitting a recover client prop. (#4522) * Add cmd for submitting a recover client prop. * Bump cosmossdk in e2e. * Use govtypes.ModuleName, rename old govtypes to govv1beta1 * Update modules/core/02-client/client/cli/tx.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Add auth flag. --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> * rename command * docs: fixed broken links (#4571) * Add e2e test for recovering a client. (#4543) Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com> * feat: add unpacket inerfaces message assertion (#4588) * add cli for MsgIBCSoftwareUpgrade (#4558) * docs: use MsgRecoverClient in docs (#4580) * docs: recover client update * Update docs/ibc/proposals.md * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <carlos@interchain.io> --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * refactor: remove legacy client update proposal (#4581) * refactor: remove legacy client update proposal * e2e: swap from ClientUpdateProposal e2e to RecoverClient * refactor: remove unused events * feat: add proposal simulator interface function and tests (#4466) Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com> * refactor!: remove UpgradeProposal type (#4602) * create separate event emission for ibc software upgrades vs an upgraded client (#4594) * add new event type * update event name * fix build * remove: legacy event emissions * remove: unnecessary assignments, apply suggestion from code review * e2e: schedule IBC software upgrade (#4585) * wip e2e test * query proposal * update upgrade height in plan * rm unnecessary wait/authority * rm test artifact from merge * add checks for scheduled plan * hook up upgrade query client * plan height * pr fixes * update test * import space * update newchainID value * update clientID upgrade * linter * gci * rm unnecessary event --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Sishir Giri <sis1001@berkeley.edu> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: catShaark <gundamaster5@gmail.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> * chore: docs for MsgIBCSoftwareUpgrade (#4601) * chore: update docs for UpgradeProposal -> MsgIBCSoftwareUpgrade * chore: anticipate link change * fix event docs * refactor: s.Assert -> s.Require * Apply suggestions from code review Co-authored-by: Damian Nolan <damiannolan@gmail.com> * make proto-all * chore: update compiler assertion * refactor: ordering, order as follows: create, update, upgrade, misbheaviour, recover, ibcsoftwareupgrade, update params * refactor: simplify ibc software upgrade emitted event * lint lint lint * Apply suggestions from code review Co-authored-by: Charly <charly@interchain.io> * review of feat/govv1 * pr nits * fix tests for error wrapping --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Charly <charly@interchain.io> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sishir Giri <sis1001@berkeley.edu> Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: catShaark <gundamaster5@gmail.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com>

charleenfei added 3 commits September 4, 2023 17:50

add cli

f579e37

use flag to fetch authority

3a69f39

typo

3f7d5ec

charleenfei requested review from colin-axner, AdityaSripal and damiannolan as code owners September 4, 2023 15:57

charleenfei commented Sep 4, 2023

View reviewed changes

crodriguezvega approved these changes Sep 5, 2023

View reviewed changes

modules/core/02-client/client/cli/tx.go Outdated Show resolved Hide resolved

modules/core/02-client/client/cli/tx.go Outdated Show resolved Hide resolved

modules/core/02-client/client/cli/tx.go Outdated Show resolved Hide resolved

charleenfei added 2 commits September 5, 2023 10:37

update for pr review

d7ed9fd

unexport CLI tx handlers

8fd8bb9

damiannolan approved these changes Sep 5, 2023

View reviewed changes

modules/core/02-client/client/cli/cli.go Outdated Show resolved Hide resolved

chatton approved these changes Sep 5, 2023

View reviewed changes

Merge branch 'feat/govv1' into charly/issue#3673-cli

cf61020

DimitrisJim reviewed Sep 6, 2023

View reviewed changes

charleenfei added 6 commits September 6, 2023 10:52

pr review comments

99e231c

format cli text

b081072

suffix changes

82b8a3b

update method names

71bd5b1

rm temp.json

0f08997

wrap errors

9e5cc43

charleenfei merged commit a374631 into feat/govv1 Sep 6, 2023
51 checks passed

charleenfei deleted the charly/issue#3673-cli branch September 6, 2023 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add cli for MsgIBCSoftwareUpgrade #4558

add cli for MsgIBCSoftwareUpgrade #4558

charleenfei commented Sep 4, 2023

charleenfei Sep 4, 2023

crodriguezvega Sep 5, 2023

charleenfei Sep 5, 2023 •

edited

Loading

charleenfei Sep 5, 2023

charleenfei Sep 6, 2023

charleenfei Sep 6, 2023

crodriguezvega left a comment

damiannolan left a comment

chatton left a comment

DimitrisJim Sep 6, 2023

charleenfei Sep 6, 2023

add cli for MsgIBCSoftwareUpgrade #4558

add cli for MsgIBCSoftwareUpgrade #4558

Conversation

charleenfei commented Sep 4, 2023

Description

charleenfei Sep 4, 2023

Choose a reason for hiding this comment

crodriguezvega Sep 5, 2023

Choose a reason for hiding this comment

charleenfei Sep 5, 2023 • edited Loading

Choose a reason for hiding this comment

charleenfei Sep 5, 2023

Choose a reason for hiding this comment

charleenfei Sep 6, 2023

Choose a reason for hiding this comment

charleenfei Sep 6, 2023

Choose a reason for hiding this comment

crodriguezvega left a comment

Choose a reason for hiding this comment

damiannolan left a comment

Choose a reason for hiding this comment

chatton left a comment

Choose a reason for hiding this comment

DimitrisJim Sep 6, 2023

Choose a reason for hiding this comment

charleenfei Sep 6, 2023

Choose a reason for hiding this comment

charleenfei Sep 5, 2023 •

edited

Loading