Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBC module level errors #3184

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Feb 21, 2023

Description

part of: #2896

This PR duplicates the errors found here and uses the ibc as the module name. They will be used in a follow up PR.

Commit Message / Changelog Entry

N/A

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan
Copy link
Member

What do you think about assigning the ibc module name to a codespace constant and using that in the calls to Register?

const codespace = exported.ModuleName

@chatton
Copy link
Contributor Author

chatton commented Feb 21, 2023

What do you think about assigning the ibc module name to a codespace constant and using that in the calls to Register?

const codespace = exported.ModuleName

don't feel strongly either way! Happy to make this change if you think it makes things clearer

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks @chatton 🙂

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be great to have deprecation warnings gone after this migration! Thanks ❤️

@chatton chatton enabled auto-merge (squash) February 22, 2023 12:00
@chatton chatton merged commit 761277a into main Feb 22, 2023
1 check passed
@chatton chatton deleted the cian/issue#2896-migrate-error-packages branch February 22, 2023 12:07
mergify bot pushed a commit that referenced this pull request Mar 9, 2023
(cherry picked from commit 761277a)
damiannolan pushed a commit that referenced this pull request Mar 9, 2023
(cherry picked from commit 761277a)

Co-authored-by: Cian Hatton <cian@interchain.io>
mergify bot pushed a commit that referenced this pull request Apr 1, 2023
(cherry picked from commit 761277a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants