Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(testing): use testing.TB instead of testing.T #3138

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Feb 13, 2023

Description

Currently, the testing package only supports unit testing through testing.T. This PR refactors the ibc testing package to support testing.B (benchmarks) and testing.F (fuzz) tests.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@fedekunze
Copy link
Contributor Author

tests failures seem to be unrelated

@damiannolan
Copy link
Member

tests failures seem to be unrelated

sometimes e2e tests will fail intermittently with docker network related errors, I wouldn't worry about it.
I kicked off the failing test to run again.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fedekunze!

@colin-axner colin-axner enabled auto-merge (squash) February 13, 2023 16:18
@colin-axner colin-axner merged commit af0c35a into main Feb 13, 2023
@colin-axner colin-axner deleted the fedekunze/testing-tb branch February 13, 2023 16:21
stackman27 pushed a commit to stackman27/ibc-go that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants